Unblocking a dll from the upper part of the about:third-party page (before the page is fully updated) causes other dll's to be unblocked as well
Categories
(Firefox :: Launcher Process, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox108 | --- | unaffected |
| firefox109 | --- | unaffected |
| firefox110 | + | verified |
People
(Reporter: emilghitta, Assigned: gstoll)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(3 files)
removesallDLLFromBlocklist.gif
Found in
- Firefox 110.0a1 (BuildId:20230106095123)
Affected versions
- Firefox 110.0a1 (BuildId:20230106095123)
Tested platforms
- Affected platforms: All Windows.
- Unaffected platforms: macOS & ubuntu.
Preconditions
- Have Google Drive for desktop (https://www.google.com/drive/download/) or TortoiseGit (https://tortoisegit.org/) installed.
Steps to reproduce
- Access the about:third-party page.
- Hit CTRL + O.
- Close the File Explorer and refresh the about:third-party page.
- Block the TortoiseGit.dll.
- Click on "Restart Nightly now" when prompted.
- Close the File Explorer and refresh the about:third-party page.
- Block the drivefsext.dll.
- Click on "Restart Nightly now" when prompted.
- Unblock the drivefsext.dll from the top of the about:third-party page.
- Click on "Restart Nightly now" when prompted.
- Hit CTRL + O.
- Close the File Explorer and refresh the about:third-party page.
Expected result
- Only the drivefsext.dll was unblocked.
Actual result
- Both drivefsext.dll and the TortoiseGit.dll were unblocked.
Regression range
I suspect that the fix for Bug 1808727 may have introduced this regression. (I can't reproduce with a build before that patch).
|
Reporter | |
Comment 1•2 years ago
|
||
I think that the following scenario is similar to the one described in this bug (probably the root cause is the same):
- Access the about:third-party page.
- Hit CTRL + O.
- Close the File Explorer and refresh the about:third-party page.
- Block the TortoiseGit.dll.
- Click on "Restart Nightly now" when prompted.
- Close the File Explorer and refresh the about:third-party page.
- Unblock the TestDllBlocklist_UserBlocked.dll.
- Click on "Restart Nightly now" when prompted.
Same as the issue described above, the other dll's are getting unblocked (TortoiseGit.dll). The testDllBlocklist_UserBlocked.dll is still blocked (as it should). But this should not cause TortoiseGit to get unblocked.
|
||
Comment 2•2 years ago
|
||
:gstoll, since you are the author of the regressor, bug 1808727, could you take a look?
For more information, please visit auto_nag documentation.
|
Assignee | |
Comment 3•2 years ago
|
||
I don't think this is actually caused by the fix to bug 1808727, but fixing that may have exposed this problem. Anyway, nice catch! I'll take a look.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 4•2 years ago
|
||
I believe this is timing-related - if you click to unblock a module before the background task finishes, the list of blocked modules won't be populated yet and so we will write an incomplete list to the blocklist file. I haven't been able to reproduce this on my system but believe I have a fix.
|
|
Assignee | |
Comment 5•2 years ago
|
||
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 8•2 years ago
|
||
This issue is verified fixed using Firefox 110.0a1 (BuildId:20230109212101) on Windows 10 64bit & Windows 11 64bit.
Previously blocked dlls cannot be unblocked before the dll list was loaded (The unblock button is disabled). The symptoms described in the bug description and in comment 1 (other dlls are wrongly unblocked) are no longer reproducible if unblocking the dlls after the list was loaded and the unblock button becomes active.
Description
•